Allow decodeBase64 to work with nested variables#2777
Draft
somiljain2006 wants to merge 3 commits intojenkinsci:masterfrom
Draft
Allow decodeBase64 to work with nested variables#2777somiljain2006 wants to merge 3 commits intojenkinsci:masterfrom
somiljain2006 wants to merge 3 commits intojenkinsci:masterfrom
Conversation
timja
requested changes
Feb 1, 2026
Member
timja
left a comment
timja
left a comment
There was a problem hiding this comment.
I don't think we want this it seems to be workarounds for something that needs cleaning up elsewhere.
I haven't looked at this in detail and don't have the answer but I don't think this is the solution
Contributor
Author
|
Thanks for the feedback. I initially chose this approach because the crash occurs when decodeBase64 is evaluated eagerly on unresolved variables. My goal was to handle that specific exception so the multi-pass resolver could continue and resolve the inner variable. However, I agree that patching the lookup feels like a workaround and that the issue should be addressed more cleanly. I will close this PR for now to propose a better solution and will return with a new proposal once I have it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow decodeBase64 to work correctly when its input is resolved from another secret source (e.g., environment variables), instead of failing during configuration loading.
Fixes #2488
Testing Done
decodeBase64, including SSH credentials.Your checklist for this pull request
🚨 Please review the guidelines for contributing to this repository.